Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eloquent models use to HasCamelCasing trait #10234

Closed
3 tasks done
taslangraham opened this issue Jul 22, 2024 · 1 comment
Closed
3 tasks done

Update eloquent models use to HasCamelCasing trait #10234

taslangraham opened this issue Jul 22, 2024 · 1 comment
Assignees
@taslangraham
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@taslangraham
Copy link
Contributor

taslangraham commented Jul 22, 2024 •
edited
Loading

Describe the bug
The eloquence package was introduced in pkp-lib via #10129. This package provides a trait that enables seamless camelCase interaction with Eloquent model attributes, eliminating the need for explicitly defined accessors and mutators.

More models can be updated to use this trait, namely:

  • InvitationModel
  • UserGroupStage
  • UserUserGroup

What application will be affected?
PKP Lib(main). Potentially OJS, OMP or OPS main.

PRs
pkp lib - #10250
ojs - pkp/ojs#4384
omp - pkp/omp#1661
ops -pkp/ops#742
@taslangraham taslangraham mentioned this issue Jul 25, 2024
Merged
@jonasraoni jonasraoni added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jul 28, 2024
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Jul 28, 2024
This was referenced Aug 1, 2024
Open
Open
Open
@taslangraham taslangraham self-assigned this Aug 1, 2024
@defstat
Copy link
Collaborator

defstat commented Aug 6, 2024

@taslangraham everything merged - I am closing the issue.

@defstat defstat closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taslangraham taslangraham

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
3 participants
@jonasraoni @defstat @taslangraham