Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Invitation Toolset support #10459

Closed
5 tasks done
defstat opened this issue Sep 20, 2024 · 2 comments
Closed
5 tasks done

Extend Invitation Toolset support #10459

defstat opened this issue Sep 20, 2024 · 2 comments
Assignees
Milestone

Comments

@defstat
Copy link
Collaborator

defstat commented Sep 20, 2024

Describe the change
Enhancement of the Invitation API and General Invitation Toolset

Invitation API Changes:

  • Role Assignment: Extend the Invitation API to support Role Assignment for both existing and new users.
  • Validation Handling: Implement Laravel's Validation API to improve the handling of validation errors in the Invitation API.
  • API Resources: Use Laravel API Resources to return the Invitation object in a consistent format.

General Invitation Toolset Changes:

  • Invitation Structure: Change the invitation structure so that each invitation is placed in its own folder.
  • Code Reduction: Refactor the invitation toolset to minimize code. Specifically, move the accept/decline logic to dedicated handlers (e.g., API Handlers) to reduce complexity in the invitation logic.

PRs

PKP-LIB: #10472

OJS: pkp/ojs#4448
OMP: pkp/omp#1708
OPS: pkp/ops#778

@defstat defstat self-assigned this Sep 20, 2024
defstat added a commit to defstat/pkp-lib that referenced this issue Sep 26, 2024
defstat added a commit to defstat/omp that referenced this issue Sep 26, 2024
defstat added a commit to defstat/ops that referenced this issue Sep 26, 2024
defstat added a commit to defstat/ojs that referenced this issue Sep 26, 2024
defstat added a commit to defstat/pkp-lib that referenced this issue Sep 26, 2024
defstat added a commit to defstat/ojs that referenced this issue Sep 26, 2024
defstat added a commit to defstat/omp that referenced this issue Sep 26, 2024
defstat added a commit to defstat/ops that referenced this issue Sep 26, 2024
defstat added a commit to pkp/ops that referenced this issue Sep 26, 2024
[OPS][main] #10459 Add support for role assignment invitation
defstat added a commit to pkp/omp that referenced this issue Sep 26, 2024
[OMP][main] #10459 Add support for role assignment invitation
defstat added a commit to pkp/ojs that referenced this issue Sep 26, 2024
[OJS][main] #10459 Add support for role assignment invitation
@defstat
Copy link
Collaborator Author

defstat commented Sep 26, 2024

@asmecher everything merged

@defstat defstat closed this as completed Sep 26, 2024
@asmecher
Copy link
Member

Excellent, thanks! 🎉

@asmecher asmecher added this to the 3.5 Internal milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants