Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest adding rel="nofollow" to links used by citation plugin #10474

Closed
jnugent opened this issue Sep 26, 2024 · 8 comments
Closed

Suggest adding rel="nofollow" to links used by citation plugin #10474

jnugent opened this issue Sep 26, 2024 · 8 comments
Assignees
Milestone

Comments

@jnugent
Copy link
Member

jnugent commented Sep 26, 2024

Describe the bug
The citation style language plugin depends upon a list of citation formats with full links containing information to generate the citation format, e.g.

....../citationstylelanguage/get/associacao-brasileira-de-normas-tecnicas?submissionId=21727&publicationId=29453

And these links can be crawled by search engines and can end up being found in results, looking like:

SPEE_URL

Suggest adding a rel="nofollow" attribute to the anchor tag used in the article_details.tpl template to prevent these from being indexed.

https://github.com/pkp/ojs/blob/stable-3_3_0/templates/frontend/objects/article_details.tpl#L350

Google seems to really like to crawl these:

Screenshot from 2024-09-26 10-21-34

What application are you using?
OJS 3.3 and 3.4

@kaitlinnewson kaitlinnewson self-assigned this Sep 26, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Sep 27, 2024
@kaitlinnewson
Copy link
Member

kaitlinnewson commented Sep 27, 2024

PRs for review

Some other discussion of this issue can be found in pkp/ojs#2465. I went with the "nofollow" solution as an alternative to changes to robots.txt, and am assuming we won't be making major changes to the citations in 3.3.

If approved, I'll forward-port to the citationStyleLanguage plugin for 3.4/main, as this part of the template has been moved.

This can also be added in any theme for 3.3 that is overriding this template.

@asmecher
Copy link
Member

Thanks, @kaitlinnewson, that makes sense. Please go ahead and port and merge forward! I've merged the stable-3_3_0 PR.

@asmecher asmecher added this to the 3.3.0-20 milestone Sep 27, 2024
kaitlinnewson added a commit to kaitlinnewson/citationStyleLanguage that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/citationStyleLanguage that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to pkp/citationStyleLanguage that referenced this issue Oct 1, 2024
pkp/pkp-lib#10474 add nofollow to citationstylelanguage links
kaitlinnewson added a commit to pkp/citationStyleLanguage that referenced this issue Oct 1, 2024
pkp/pkp-lib#10474 add nofollow to citationstylelanguage links
@kaitlinnewson
Copy link
Member

Forward-ported and merged!

@asmecher Are submodule updates also needed for 3.4/main, or will that be done closer to the next releases?

@jnugent
Copy link
Member Author

jnugent commented Oct 1, 2024

Hi @kaitlinnewson the PKP PS team appreciates having the submodule updates in stable-3_4 as they are needed because we track the stable branches for our hosted installations, rather than working off of release packages. We routinely update installs by just pulling down recent commits and updating sub modules as necessary.

kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/ops that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/omp that referenced this issue Oct 1, 2024
kaitlinnewson added a commit to kaitlinnewson/ops that referenced this issue Oct 1, 2024
@kaitlinnewson
Copy link
Member

bozana added a commit to pkp/ojs that referenced this issue Oct 1, 2024
bozana added a commit to pkp/ops that referenced this issue Oct 1, 2024
@bozana
Copy link
Collaborator

bozana commented Oct 1, 2024

Hi @kaitlinnewson, I merged OJS and OPS, waiting for OMP tests, when all pass successfully I will merge it too.
Main branch does not necessarily need to be updated -- lots of changes currently happening there... but because it is citationStyleLanguage submodule it will not disturb the others so I can merge them too when tests pass...

bozana added a commit to pkp/ops that referenced this issue Oct 1, 2024
bozana added a commit to pkp/ojs that referenced this issue Oct 1, 2024
bozana added a commit to pkp/omp that referenced this issue Oct 1, 2024
bozana added a commit to pkp/omp that referenced this issue Oct 4, 2024
@bozana
Copy link
Collaborator

bozana commented Oct 4, 2024

All merged... :-)

@kaitlinnewson
Copy link
Member

Thanks @bozana! Closing this as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants