-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest adding rel="nofollow" to links used by citation plugin #10474
Comments
PRs for review
Some other discussion of this issue can be found in pkp/ojs#2465. I went with the "nofollow" solution as an alternative to changes to robots.txt, and am assuming we won't be making major changes to the citations in 3.3. If approved, I'll forward-port to the citationStyleLanguage plugin for 3.4/main, as this part of the template has been moved. This can also be added in any theme for 3.3 that is overriding this template. |
Thanks, @kaitlinnewson, that makes sense. Please go ahead and port and merge forward! I've merged the |
pkp/pkp-lib#10474 add nofollow to citationstylelanguage links
pkp/pkp-lib#10474 add nofollow to citationstylelanguage links
Forward-ported and merged! @asmecher Are submodule updates also needed for 3.4/main, or will that be done closer to the next releases? |
Hi @kaitlinnewson the PKP PS team appreciates having the submodule updates in stable-3_4 as they are needed because we track the stable branches for our hosted installations, rather than working off of release packages. We routinely update installs by just pulling down recent commits and updating sub modules as necessary. |
Submodule update PRs - 3.4:
main:
@bozana Are you able to merge the 3.4 submodule PRs? This is already done for 3.3 as the change was in the core theme then and not in the CSL plugin. |
pkp/pkp-lib#10474 submodule update for csl plugin
pkp/pkp-lib#10474 submodule update for csl plugin
Hi @kaitlinnewson, I merged OJS and OPS, waiting for OMP tests, when all pass successfully I will merge it too. |
pkp/pkp-lib#10474 submodule update for csl plugin
pkp/pkp-lib#10474 submodule update for csl plugin
pkp/pkp-lib#10474 submodule update for csl plugin
pkp/pkp-lib#10474 submodule update for csl plugin
All merged... :-) |
Thanks @bozana! Closing this as completed. |
Describe the bug
The citation style language plugin depends upon a list of citation formats with full links containing information to generate the citation format, e.g.
....../citationstylelanguage/get/associacao-brasileira-de-normas-tecnicas?submissionId=21727&publicationId=29453
And these links can be crawled by search engines and can end up being found in results, looking like:
Suggest adding a
rel="nofollow"
attribute to the anchor tag used in thearticle_details.tpl
template to prevent these from being indexed.https://github.com/pkp/ojs/blob/stable-3_3_0/templates/frontend/objects/article_details.tpl#L350
Google seems to really like to crawl these:
What application are you using?
OJS 3.3 and 3.4
The text was updated successfully, but these errors were encountered: