Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue archives show non-existent paginated results #10596

Closed
NateWr opened this issue Nov 11, 2024 · 2 comments
Closed

Issue archives show non-existent paginated results #10596

NateWr opened this issue Nov 11, 2024 · 2 comments
Milestone
3.3.0-20

Comments

@NateWr
Copy link
Contributor

NateWr commented Nov 11, 2024

Describe the bug
The issue archive handler will show the issue archive for pages of results that don't exist. For example, if a journal only has 5 pages of results, /issue/archive/23 will show a message that says "This journal has not published any issues."

To Reproduce
Steps to reproduce the behavior:

  1. See example in public demo at https://ojs33.demo.publicknowledgeproject.org/index.php/demojournal/issue/archive/10

What application are you using?
OJS stable-3_3_0

Additional information
I believe it should show a 404 error on such pages. PR incoming.
NateWr added a commit to NateWr/ojs that referenced this issue Nov 11, 2024
@NateWr
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
c2a865f
NateWr added a commit to NateWr/ojs that referenced this issue Nov 11, 2024
@NateWr
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
691af33
NateWr added a commit to NateWr/ojs that referenced this issue Nov 11, 2024
@NateWr
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
ff81cf1
@NateWr
Copy link
Contributor Author

NateWr commented Nov 11, 2024

The following PRs return a 404 response when a page is accessed that doesn't exist.

PRs:
pkp/ojs#4514 (stable-3_3_0)
pkp/ojs#4515 (stable-3_4_0)
pkp/ojs#4516 (main)

asmecher pushed a commit to pkp/ojs that referenced this issue Nov 12, 2024
@NateWr @asmecher
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
2fe5813
asmecher pushed a commit to pkp/ojs that referenced this issue Nov 12, 2024
@NateWr @asmecher
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
8a92a39
asmecher pushed a commit to pkp/ojs that referenced this issue Nov 12, 2024
@NateWr @asmecher
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
b4f2c16
@asmecher
Copy link
Member

All merged, thanks!

@asmecher asmecher added this to the 3.3.0-20 milestone Nov 12, 2024
GaziYucel pushed a commit to GaziYucel/ojs that referenced this issue Nov 15, 2024
@NateWr @GaziYucel
pkp/pkp-lib#10596 Fix: issue archives show pages that don't exist
fbcb8ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0-20
Development

No branches or pull requests
2 participants
@asmecher @NateWr