Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the current page on the top menu #5199

Open
israelcefrin opened this issue Oct 18, 2019 · 3 comments
Open

Set the current page on the top menu #5199

israelcefrin opened this issue Oct 18, 2019 · 3 comments
Assignees
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.

Comments

@israelcefrin
Copy link
Collaborator

israelcefrin commented Oct 18, 2019

Our accessibility audit recommended to include a visual status on the top menu for the current page.
Currently it is not visible from the menu which page or section the user is viewing.

On that note, it is recommended to enable on the menu the aria-current="page" on link item menu for screenreaders being able to announce the current page link to the user.

@israelcefrin israelcefrin added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Oct 18, 2019
@israelcefrin
Copy link
Collaborator Author

@Vitaliy-1 are you currently working on some issue related to this request for marking the current page on top menu?

@israelcefrin
Copy link
Collaborator Author

Hi @jardakotesovec ,
Just bringing your question from pkp/ojs#4133 to this issue:

should not we also update the other cases to be links? For example if we go to /index.php/publicknowledge/about, than About the Journal is not link.

Since the " about " element is not a link to anywhere but a menu opener, it should be changed from <a href.. to <button> element. We can even open an issue just for this improvement since it will require HTML/CSS and JS tweaking.

See the W3C website menu . It opens, closes, showing an icon change and highlight color to show when active.

@israelcefrin
Copy link
Collaborator Author

israelcefrin commented Jan 25, 2024

Hi @jardakotesovec , here are the PRs to OMP and OPS 3.4:
OMP 3.4 PR - pkp/omp#1505
OPS 3.4 PR - pkp/ops#620

israelcefrin added a commit to israelcefrin/ojs that referenced this issue Jan 26, 2024
israelcefrin added a commit to israelcefrin/ops that referenced this issue Jan 26, 2024
israelcefrin added a commit to israelcefrin/ojs that referenced this issue Jan 26, 2024
israelcefrin added a commit to israelcefrin/omp that referenced this issue Jan 26, 2024
jonasraoni added a commit to israelcefrin/omp that referenced this issue Jan 26, 2024
jonasraoni added a commit to israelcefrin/ops that referenced this issue Jan 26, 2024
jonasraoni added a commit to israelcefrin/omp that referenced this issue Jan 26, 2024
@israelcefrin israelcefrin moved this from Backlog to Under Development in Reader Interface Feb 3, 2024
@asmecher asmecher moved this to Backlog in Accessibility Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Status: Backlog
Status: Under Development
Development

No branches or pull requests

2 participants