Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS/OMP] Ability to send review reminders prior to due date #5885

Closed
alexxxmendonca opened this issue May 15, 2020 · 22 comments
Closed

[OJS/OMP] Ability to send review reminders prior to due date #5885

alexxxmendonca opened this issue May 15, 2020 · 22 comments
Assignees
Labels
Enhancement:3:Major A new feature or improvement that will take a month or more to complete. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Milestone

Comments

@alexxxmendonca
Copy link
Contributor

alexxxmendonca commented May 15, 2020

Describe the problem you would like to solve
Reviewers are informed only after the review deadline has reached, not before. If they are notified before, it could increase chances of getting reviews before the deadline and by extent shortening the overall manuscript evaluation time.

Describe the solution you'd like
Ability to send review reminders prior to the due date.

Who is asking for this feature?
See:
https://forum.pkp.sfu.ca/t/automatic-reminder-for-upcoming-review-deadline/50580
https://forum.pkp.sfu.ca/t/reminder-for-reviewers-that-the-review-is-due-soon/51907

PRs
pkp-lib --> #9612
ui-library --> pkp/ui-library#333
ojs --> pkp/ojs#4141
omp --> pkp/omp#1555
ops --> pkp/ops#749 [TEST ONLY]

Screenshots
New look based on @Devika008 's design
CleanShot 2024-04-22 at 18 08 28@2x

@NateWr
Copy link
Contributor

NateWr commented May 18, 2020

Probably what we want here is a tool for configuring reminders that lets the journal set up a reminder, define when it occurs (X days before/after due date), and configure the email that is sent.

@NateWr NateWr added the Enhancement:3:Major A new feature or improvement that will take a month or more to complete. label May 18, 2020
@pmangahis
Copy link

pmangahis commented May 19, 2021

+1 from Hosted journal

@pmangahis pmangahis added the Hosting Bug reports and feature requests from Publishing Services's hosted clients. label May 19, 2021
@pmangahis
Copy link

+1 from Hosted journal

@ajnyga
Copy link
Collaborator

ajnyga commented Oct 26, 2021

+1 We recently had this same request

@librariam
Copy link
Collaborator

+1 more from PKP|PS

@twakeford
Copy link

Reminders before the due date as well after gets a big thumbs up from Ubiquity. We get this request very frequently.

@trobb49
Copy link

trobb49 commented Mar 31, 2022

Actually, I'm surprised that this function is not already available. It is much "friendlier" to remind reviewers early, than to embarrass them afterward by telling them that they have already missed their deadline. Also, the chances are that they are notified after the due date, they will not produce as good a review since they will feel rushed.
The major journal publishers have their own dedicated systems that do include this feature.

@forgive38
Copy link
Contributor

+1 from our editors

@forgive38
Copy link
Contributor

Do you think reminder before date should be only for review due date or for review request due date too ?

Should we have a dedicated email template ?

I propose to extend the current management of delay for reminder:
sample

@trobb49
Copy link

trobb49 commented Sep 30, 2022

Both would be great. The code would be, I imagine, very similar so why not implement both? I'm excited!

@NateWr
Copy link
Contributor

NateWr commented Oct 3, 2022

I propose to extend the current management of delay for reminder:

We only support one email at the moment. If we extend it to support more than one email, we should turn it into a more flexible system that allows journals to configure as many reminders as they want.

Given our timeline for 3.4, we don't have time to work on multiple emails. So I would suggest extending the existing field to support negative numbers. That would be one email which could be sent before or after the deadline, depending on the setting.

@trobb49
Copy link

trobb49 commented Oct 3, 2022

Supporting negative numbers would be a brilliant quick fix and would keep people happy until 3.5, I think.

@forgive38
Copy link
Contributor

Why not ... but this implies that there is no other reminder when the reviewer is late, and the template mail of reminder should be modified by editors in case of negative delay (verb tense future vs past tense)

@touhidurabir touhidurabir self-assigned this Jan 4, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 11, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 11, 2024
@touhidurabir
Copy link
Member

@Vitaliy-1 can you please review the PR at #5885 (comment) .

The above PR contains several update as follow

  • ability to set up review response and submit remainder for both before and after days as proposed at [OJS/OMP] Ability to send review reminders prior to due date #5885 (comment) .
  • update of the previous settings name as remainder mail was sent after but name was defined as before which is confusing.
  • when adding a new reviewer, it is possible to set a lower review submit date than the review response date which seems bit off logic as reviewer first need to respond to request and then submit review if accepted . The corresponding validation added to backend to avoid this case.
  • moved the logic to send remainder mail to queue job .

More possible enhancement :

  • add a fronted validation also to handle review response due date must be before the review submit due date that match up with the backed validation .
  • when adding a new reviewer, the notification in case of any issue does not show up immediately but after a page reload . this can be fixed also .

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/omp that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 30, 2024
touhidurabir added a commit to touhidurabir/ops that referenced this issue Aug 30, 2024
@touhidurabir
Copy link
Member

@asmecher all rebased . If all tests passes, should be good to merge .

@pilasou
Copy link

pilasou commented Aug 30, 2024

Thanks @touhidurabir, this is a great improvment. As part of it I suggested to offer the ability to set a 2nd reminder. See my whole comment on this issue: #5885 (comment). Is this part of this improvment? Thank you.

asmecher pushed a commit that referenced this issue Aug 30, 2024
* #5885 Review remainder update

* #5885 Review remainder update issues fixed

* #5885 typo fixed

* #5885 update remainder calculation

* #5885 removed unnecessary select from migration

* #5885 updated and added new from component to handle reminder

* #5885 removed unnecessary fields and controls with field range component enhancement

* #5885 updated using new slider component

* #5885 updated job class properties to public

* #5885 updated date validation rules to enum

* #5885 fixed displaying error on date comparison validation failure

* #5885 test added for queue job

* #5885 added mocked context service and context class for job testing

* #5885 added context checking first if available to resolve context path before resolving from request

* #5885 job test update

* #5885 job test update

* #5885 removed mistakenly pulled BaseInvitation during rebase

* #5885 updated job and test based on new inviation functionality implementation

* #5885 updated task

* #5885 translation update

* #5885 tests updated and removed reference of deprecated Services class

* #5885 test update

* #5885 test update
asmecher pushed a commit to pkp/ui-library that referenced this issue Aug 30, 2024
* pkp/pkp-lib#5885 updated and added new UI component

* pkp/pkp-lib#5885 fixed issue with value updating in db

* pkp/pkp-lib#5885 removed unnecessary fields and controls with field range component enhancement

* pkp/pkp-lib#5885 updated using new slider component

* pkp/pkp-lib#5885 fixed merged conflict
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 30, 2024
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 30, 2024
asmecher pushed a commit to pkp/ojs that referenced this issue Aug 30, 2024
asmecher pushed a commit to pkp/omp that referenced this issue Aug 30, 2024
asmecher pushed a commit to pkp/omp that referenced this issue Aug 30, 2024
@asmecher
Copy link
Member

@touhidurabir, all merged, thanks! Closing this issue.

@touhidurabir
Copy link
Member

Thanks @touhidurabir, this is a great improvment. As part of it I suggested to offer the ability to set a 2nd reminder. See my whole comment on this issue: #5885 (comment). Is this part of this improvment? Thank you.

@pilasou This is close but not exactly what describe in #9455 . For this one, reviewer can get max 2 sets of reminder as

  1. one before x days of response due date and one after x days after the response due date
  2. one before x days of submit due date and one after x days after the submit due date

If I am not mistaken, what #9455 propose is multiple reminder occurrences before/after due dates which will JM/Editor can configure has not been implemented in it .

But perhaps this compensate enough what proposed in #9455 as reviewer get 2 reminder for response and 2 reminders for submit and configureable by x number of days .

@pilasou
Copy link

pilasou commented Sep 3, 2024

Hi @touhidurabir thanks. I tend to consider that with your new feature the reminders (4 reminders can be configured) can be an answer to #9455. Our journals have mainly configured 2 reminders per type (response due, submission due). For this reason, I think #9455 may be closed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:3:Major A new feature or improvement that will take a month or more to complete. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
Status: Done
Status: Done
Development

No branches or pull requests