-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Accept-Language header when assigning a default language to a new user session #7512
Comments
@jonasraoni the link isn't taking me directly to the comment. This happens sometimes as GitHub hides some comments. Can you copy/paste the discussion or reasoning into this issue? |
Ah, so this is during installation. I've updated the issue title/description, thanks! |
@NateWr, no, this isn't for during installation -- it's for when a user without a session first hits the OJS website. |
Ok, then I'm not understanding the issue description. Can one of you (@jonasraoni, @asmecher) update this with a clearer description of the problem and solution? |
@jonasraoni and @NateWr, I've updated the description. @jonasraoni, did I capture what you were proposing? |
Got it, thanks! |
…accept-language##
…accept-language##
…accept-language##
…accept-language##
…accept-language##
… match with the Accept-Language header
…accept-language##
… match with the Accept-Language header
…accept-language##
…accept-language##
…accept-language##
…accept-language##
@asmecher Some older PRs which I've rebased recently, so they are still ok to be merged. |
@jonasraoni I don't think anyone has identified this as a priority so I haven't reviewed it; strategically, I would much rather we considered e.g. adopting Laravel's session management toolset rather than refining our own. |
… match with the Accept-Language header
…accept-language##
… match with the Accept-Language header
…accept-language##
Describe the problem you would like to solve
When a user accesses an OJS (OMP, OPS) website, OJS creates a session and assigns the primary locale to it. This becomes the default language the user will work with while interacting with the website, until he changes it. However, this may not correspond to the user's preferred language.
Describe the solution you'd like
Instead of using the primary locale, we should use the
Accept-Language
header to detect the user's current locale and automatically select that (if available).Who is asking for this feature?
No user requests yet.
PRs
Additional information
Reference: #7336 (comment)
The text was updated successfully, but these errors were encountered: