Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve current e2e tests reliability #9973

Closed
jardakotesovec opened this issue May 21, 2024 · 3 comments
Closed

Improve current e2e tests reliability #9973

jardakotesovec opened this issue May 21, 2024 · 3 comments
Assignees
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@jardakotesovec
Copy link
Contributor

Describe the bug
Seems that lots of runs are failing on keyword component, in particular its test 60-content/CcorinoSubmission.cy.js :

request Saved
request Saved
request Saved
get #metadata-keywords-selected-en
contains Professional Development
get #metadata-keywords-selected-en
contains Social Transformation
saved as log in: cypress/logs/failed-cypress-tests-data-60-content-ccorino-submission-data-suite-ccorino-sends-to-review-and-selects-pre-existing-keywords.json
    ✓ Logins as a section editor and recommends accept (14304ms)


  2 passing (46s)
  1 failing

  1) Data suite: Ccorino
       Sends to review and selects pre-existing keywords:
     AssertionError: Timed out retrying after 10000ms: Expected to find content: 'Social Transformation' within the element: <div#metadata-keywords-selected-en.pkpAutosuggest__inputWrapper.pkpFormField__input.pkpAutosuggest__inputWrapper--multilingual> but never did.

What application are you using?
OJS, OMP or OPS version main

Additional information
Failed job example - https://github.com/pkp/ojs/actions/runs/9171483181/job/25215892896

@jardakotesovec jardakotesovec self-assigned this May 21, 2024
@jardakotesovec jardakotesovec added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label May 21, 2024
@jardakotesovec jardakotesovec added this to the 3.5 Internal milestone May 21, 2024
@jardakotesovec
Copy link
Contributor Author

When typing in the keyword - it would start multiple requests to get the list of keywords. Addressing that seems improved tests reliability.

ui-library: pkp/ui-library#353

jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue May 21, 2024
@jardakotesovec
Copy link
Contributor Author

jardakotesovec commented May 21, 2024

All tests passed on PR, but not after merging to main, its still moody on that keyword input.

Sometimes it fails when running cypress locally as well - but its very rare.. so difficult to trust the results.

Trying to make it type slower to see whether it improves reliability on CI:
pkp/ojs#4282

@jardakotesovec
Copy link
Contributor Author

Slowing down the typing in the keyword input seems to improve reliability enough (all tests are passed on OJS main now).
Taking it as good enough improvement for now and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

1 participant