Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HasCamelCasing trait to UserGroupStage, UserUserGroup, and InvitationModel models #10250

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

taslangraham
Copy link
Contributor

For #10234

@taslangraham taslangraham force-pushed the i10234-main branch 2 times, most recently from 09d9dbb to 202fa9f Compare July 28, 2024 18:07
@taslangraham taslangraham marked this pull request as ready for review July 29, 2024 14:06
@taslangraham
Copy link
Contributor Author

Ready for review @asmecher

@asmecher
Copy link
Member

Thanks, @taslangraham! @defstat, would you mind reviewing this?

@defstat
Copy link
Collaborator

defstat commented Aug 1, 2024

@taslangraham thanks, this trait saves so much code and it is super helpful. Can you add the necessary PRs on OJS, OMP, OPS so that the tests run on the pkp-lib PR?

@taslangraham taslangraham force-pushed the i10234-main branch 3 times, most recently from d2723e7 to 23c96fa Compare August 1, 2024 15:39
@defstat
Copy link
Collaborator

defstat commented Aug 1, 2024

If you need any help with the tests I will be happy to help.

@taslangraham
Copy link
Contributor Author

taslangraham commented Aug 1, 2024

@defstat I've added PRs for submodule updates for each app.
I've listed them here in the issue description - #10234

Copy link
Collaborator

@defstat defstat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taslangraham. Just check one test that has already failed on OMP. It could be a test glitch and could be resolved if you rerun it. But check if this is the case. Other than that I have no comments on the code

@taslangraham
Copy link
Contributor Author

@defstat all tests are now passing.

@defstat
Copy link
Collaborator

defstat commented Aug 5, 2024

Perfect, I have no other comments

@taslangraham
Copy link
Contributor Author

@defstat I don't have write access. If you do, could you please merge this?

@defstat defstat merged commit a1e4461 into pkp:main Aug 6, 2024
1 check passed
@defstat
Copy link
Collaborator

defstat commented Aug 6, 2024

@taslangraham everything merged! Thanks.

@taslangraham taslangraham deleted the i10234-main branch August 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants