Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement ExtractImagePatches' create_kernel_tensor with Range & Scatter #99

Open
tzerrell opened this issue Nov 3, 2020 · 0 comments

Comments

@tzerrell
Copy link

tzerrell commented Nov 3, 2020

I believe that we could avoid compute_shape in ExtractImagePatches' create_kernel_tensor function by using a Range op that takes a TensorDim parameter along with Scatter. However, such a Range op has not yet been implemented. Moreover, I'm not quite sure if switching to TensorDim there would get in the way of optimizations noticing that everything involved was a constant.

Investigate whether the above approach would work as desired, and if so implement it.

See also #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant