Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we clone controls in Viewer::initMapPanel? #134

Open
bartvde opened this issue Apr 5, 2012 · 0 comments
Open

should we clone controls in Viewer::initMapPanel? #134

bartvde opened this issue Apr 5, 2012 · 0 comments

Comments

@bartvde
Copy link
Contributor

bartvde commented Apr 5, 2012

Currently it is passed straight to OpenLayers and controls are added to the initial array provided.

It seems there are serialization issues with controls in any case, does it make sense to delete them from initialConfig?

                controls: mapConfig.controls ? mapConfig.controls.slice(0) : [
                    new OpenLayers.Control.Navigation({
                        zoomWheelOptions: {interval: 250},
                        dragPanOptions: {enableKinetic: true}
                    }),
                    new OpenLayers.Control.PanPanel(),
                    new OpenLayers.Control.ZoomPanel(),
                    new OpenLayers.Control.Attribution()
                ],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant