-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Failed to parse source map" errors #79
Comments
Just fixed this issue with my own module. Now, the micro-memoize is the only module which produces this error. |
Apologies for the delay in getting this resolved, life has been pretty wild the last couple of months. I have fixed this as-of version |
I believe this is happening again as of
|
@landabaso you are correct! Sorry about that ... reopening, and fixing posthaste. EDIT: Actually ... there may be a misunderstanding of the issue at hand here, and my response was jumping the gun based on the same misunderstanding from my own fallible memory 😅 . The issue is not that
The referenced locations in the original issue are: {"version":3,"file":"micro-memoize.js","sources":["../../src/utils.ts","../../src/Cache.ts","../../src/index.ts"],"sourcesContent":[null,null,null], However, since 4.0.11, the files reference the correct location which is only one folder up: {"version":3,"file":"micro-memoize.cjs.js","sources":["../src/utils.ts","../src/Cache.ts","../src/index.ts"],"sourcesContent":[null,null,null], Notice the That said, Are you experiencing any specific issue? Or did you just notice |
Hi @planttheidea , thanks for the reply and for maintaining this project. I'm getting same of errors as the OP. I use
|
Alright so there are a few options:
The last point is controversial, and I found strong opinions on both sides when searching for other packages. Do you have an opinion on the topic? The files themselves are small, so I think option 1 is probably best, but it assumes there is value from the maps at all. |
Quickly following up ... I'm actively working on V5 (smaller, faster, more full-featured) and have decided to remove source maps in this update. I've done a lot of research on what other published packages do, and there is a strong argument that little benefit exists for providing them, as there is very little indirection to debug through in the bundled version and it provides little additional context for any issues resulting from breakages discovered. No timeline on V5 delivery, but I'll keep this open until then, at which point it should be resolved. |
Hi, I'm interested in learning about the arguments on sourcemap provide little benefits. Do you found that because the gap between TS and modern JS are relative small (unlike in the old days where |
When using micro-memoize version
4.0.10
in a react application, starting the application in development mode is giving the following warnings:which then leads to some warning in following lines in the console.
Indeed, after looking at the contents of the
.map
files in the package of version4.0.10
the files are referencing two paths up, which leads to trying to look at a path outside the package:This is happening with latest version
4.0.10
. Probably, somehow, the source map files were badly generated because the previous patch version4.0.9
does not generate these warnings. I have reverted as a workaround.The text was updated successfully, but these errors were encountered: