Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO toolkit cannot locate dependency files #24

Open
chadwcarlson opened this issue Feb 17, 2023 · 1 comment
Open

SO toolkit cannot locate dependency files #24

chadwcarlson opened this issue Feb 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@chadwcarlson
Copy link
Contributor

Describe the bug

When source operations toolkit is run on Django 4, neither the Pipfile or poetry.lock file can be found.

Include some logs

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Reproducing

https://github.com/platformsh-templates/django4/actions/runs/4189911585/jobs/7262777039

Expected behavior

If anything, we would expect that - since the default app is running pip:

  • Pipfile is detected, but fails to update (pipenv not installed)
  • poetry.lock is detected, but fails to update (poetry not installed)

Your environment

See above

Screenshots

No response

Additional context

Temporary pipeline fix implemented in #23

@chadwcarlson chadwcarlson added the bug Something isn't working label Feb 17, 2023
@gilzow
Copy link
Contributor

gilzow commented Feb 22, 2023

For transparency/completeness:
The Source Operations Toolkit (SOTK) assumes that a .platform.app.yaml configuration file will be present in the same directory as a package manager file. This was done to ensure it doesn't attempt to update a package file that was committed directly to the project in some sub-sub directory but isn't actually managed by the project.

Since we're using ./.platform/applications.yaml instead of .platform.app.yaml in this template, the SOTK doesn't "see" the package manager files. We might need to rethink the logic in how we discover package management files. See platformsh/source-operations#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants