Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify gunicorn is in requirements.txt before adding as a start command #211

Open
gilzow opened this issue Mar 12, 2024 · 4 comments
Open
Labels
bug Something isn't working enhancement New feature or request Platformify

Comments

@gilzow
Copy link
Contributor

gilzow commented Mar 12, 2024

G/ is reporting that when upsun project:init detected his code as a Flask stack, the written config file included:

start: "gunicorn -b unix:$SOCKET 'app:app' --log-file -"

for web:commands:start. HOWEVER, upsun project:init did not verify that gunicorn was included in the requirements.txt and therefore the app failed to start correctly.

We need to verify that gunicorn is in requirements before adding gunicorn start command, or at least warn the user to make sure it is included.

@gilzow gilzow added bug Something isn't working enhancement New feature or request labels Mar 12, 2024
@gmoigneu
Copy link
Contributor

Another option would be to include the gunicorn in the python3 dependencies in the yaml.

@gilzow
Copy link
Contributor Author

gilzow commented Mar 12, 2024

what happens if we end up with it in both places? 🤔

@akalipetis
Copy link
Member

I am against including dependencies for the user - we should handle the case where Gunicorn is missing, but not install it for them.

@akalipetis akalipetis added the Platformify label Jul 2, 2024 — with Linear
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@gilzow gilzow reopened this Jan 6, 2025
@gilzow
Copy link
Contributor Author

gilzow commented Jan 6, 2025

re-opened as the issue is still valid (linear should not have closed the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Platformify
Projects
None yet
Development

No branches or pull requests

3 participants