Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to reconnect right after connection is closed (FIN arrived) instead of on query or ping #210

Open
ruslandoga opened this issue Nov 2, 2024 · 0 comments · May be fixed by #212
Open

Comments

@ruslandoga
Copy link
Contributor

ruslandoga commented Nov 2, 2024

Context: #208

Possible solutions:

@ruslandoga ruslandoga self-assigned this Nov 2, 2024
ananthakumaran added a commit to ananthakumaran/ch that referenced this issue Nov 9, 2024
A server may return `Connection: close` while gracefully shutting
down. Mint will mark the connection state as closed and return the
response from the server (NOTE: it will not return any error). Since
the client doesn't know the connection is closed, it will try to use
the connection for the next request and will fail.

Before making any HTTP request, check the internal state of the
connection and attempt to reconnect once if necessary.

partially related to plausible#210
ruslandoga pushed a commit that referenced this issue Nov 9, 2024
A server may return `Connection: close` while gracefully shutting
down. Mint will mark the connection state as closed and return the
response from the server (NOTE: it will not return any error). Since
the client doesn't know the connection is closed, it will try to use
the connection for the next request and will fail.

Before making any HTTP request, check the internal state of the
connection and attempt to reconnect once if necessary.

partially related to #210
@ruslandoga ruslandoga removed their assignment Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant