-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prefer-locator): Add rule to suggest not using page methods #315
Merged
mskelton
merged 9 commits into
playwright-community:main
from
carlbray:feature/prefer-page-locator-fill
Sep 19, 2024
Merged
feat(prefer-locator): Add rule to suggest not using page methods #315
mskelton
merged 9 commits into
playwright-community:main
from
carlbray:feature/prefer-page-locator-fill
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule should be more generic for all page actions that are like it. For example click is the same exact way |
Looks like their a quite a few Page methods tagged with NOTE Use locator-based now that you mention it
I'll extend it to those |
carlbray
changed the title
Add prefer-page-locator-fill
feat(prefer-locator): Add rule to suggest not using page methods
Sep 14, 2024
mskelton
reviewed
Sep 16, 2024
mskelton
reviewed
Sep 19, 2024
mskelton
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule detects where page.fill(loc, value) has been used and suggests the user uses a locator based fill as per the documentation for page.fill
https://github.com/microsoft/playwright/blob/d1926e2f9b91e31d73acfb87e564634f55b0dbb2/docs/src/api/class-page.md?plain=1#L2027