-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeout does not clean up processes started by 'command' #4
Comments
Same issue here - trying to start a webpack server but when the timeout is exceeded, jest terminates but webpack keeps on running forever |
I know that it was quite old issue. But can someone produce representation? Cause I can't figure out on the problem |
@mmarkelov I am unsure if I read your sentence correctly, but do you mean if we can explain it better? Try creating a long-running process in When |
@thernstig what is your OS? I can't reproduce it on my MAC machine |
@mmarkelov maybe this has been fixed since then? I can try again later possibly. |
@thernstig it will be nice. Also I added some cleanup functionality in catch block, so I hope it will help |
@mmarkelov I can still re-create this, so I took a look at the code. I believe I found multiple things that can cause errors, unless I am misreading the code.
jest-process-manager/src/index.ts Lines 246 to 257 in 0fd77b1
Note that this only sends a
jest-process-manager/src/index.ts Lines 258 to 260 in 0fd77b1
and this piece of code seems to properly call
Am I missing something in all of this? |
@thernstig So if I understood you correctly , I should check out the cases when port is not provided? |
Point 1 and 3 should be checked out. Point 1) is about a port being provided. Point 3) is about pressing |
Set a command like:
If the timeout occurs, you get this message:
The problem here is that
jest-process-manager
then never sends the proper signals to the processes started by thecommand
, meaning they get hanging. As a comparison, pressingctrl+c
after the server has started properly cleans up the resources.To Reproduce
Add the above config and a very short launchTimeout and notice how the started
command
never stops (check e.g. via theps
command).Expected behavior
jest-process-manager
should send the proper signals to launchedcommand
, even after alaunchTimeout
occured.The text was updated successfully, but these errors were encountered: