-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial commit #1
Conversation
@mxschmitt I'm going to start work on it. So maybe we can push some kind of init commit?) |
we if its okay for you you can either push into that branch/PR or we merge this one already. |
@mxschmitt ok! I'll push changes into this branch) |
], | ||
"scripts": { | ||
"prebuild": "rm -rf lib/", | ||
"prepublishOnly": "yarn build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should select yarn or npm to use. Cause right now there is yarn build
command, but also there is package-lock.json
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yee, thats why I mentioned it in the TODOs. Im ok with both, lets maybe use npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxschmitt I suppose using npm is better, cause we are using it for jest-playwright, so we should be consistent
- Separate defaults and types
I think we have to mention it in the LICENSE, that his is a forked version of the jest-dev-server. btw. what do you think about the name jest-process-manager? |
IDK if we should mention it in LICENSE, of course we must put it in README, I think it will be enough
That's totally fine for me ;) |
I think we can merge and release / test a version. But for the license we have to include the old one as mentioned here: https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-dev-server/LICENSE |
Yeah! I think so. We can mention them in our LICENSE, but IDK how) |
we have to include a copy of their license and then our license (MIT). |
@mxschmitt how we should include copy of their license? Like put it in |
06c3c6f
to
2eea1bd
Compare
Okay, merged for now. How should we go on? Maybe fix the README and then a first release / make it public? |
@mxschmitt yeah! I think we should fix the Readme and we are ready to go. Also it will be nice to ask @thernstig to open issues from jest-dev-server |
Did not add one for argos-ci/jest-puppeteer#340 since I assume you already fixed this. Note: I have not been able to test this package yet obviously, so it's possible you can immediately close some of the issues above if they are already considered in this new package. |
@thernstig thanks a lot! |
Theres a lot missing.
I would like to have also some tests.
TODO: