Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mux provides user with internal map #496

Open
HRogge opened this issue Oct 18, 2023 · 1 comment
Open

Mux provides user with internal map #496

HRogge opened this issue Oct 18, 2023 · 1 comment

Comments

@HRogge
Copy link
Collaborator

HRogge commented Oct 18, 2023

The Mux-router function GetRoutes() returns the user a direct "reference" to the internal map, which is NOT a copy. This defeats the purpose of the locking mechanism in the router.
@HRogge
Copy link
Collaborator Author

HRogge commented Oct 18, 2023

Should be fixed by #497

hmm... now that I look at GetRoute(), it also leaks access to the lock-protected data...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HRogge