New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature validation is insecure #223

Open

rgalanakis opened this issue Aug 6, 2023 · 0 comments

rgalanakis commented Aug 6, 2023

This line:

plivo-ruby/lib/plivo/utils.rb

Line 219 in 1190383

    
           Base64.encode64(OpenSSL::HMAC.digest(sha256_digest, auth_token, data_to_sign)).strip() == signature

Is vulnerable to timing attacks, as per https://github.com/Asmod4n/mruby-secure-compare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment