Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make serve missing bundle without first running build:webpack:docs #1386

Open
seanupton opened this issue Jun 24, 2024 · 0 comments
Open

make serve missing bundle without first running build:webpack:docs #1386

seanupton opened this issue Jun 24, 2024 · 0 comments

Comments

@seanupton
Copy link
Member

make install && make serve result in 404 errors for http://localhost:8001/dist/mockup/bundle.min.js (on any supported node version I have tried).

There is not any output to _site/dist/mockup directory (which does not exist without webpack told to output to this target directory via npx yarn run build:webpack:docs).

If the interactive documentation is the primary vehicle for someone to develop and test basic changes to patterns (in a simpler vacuum outside of plone.staticresources), it might make sense to either:

  1. Update Makefile(s) to include this by default as a dependency of make serve as some (new) bundle-docs target?
  2. Update README.md development section to mention this is an explicit additional step needed to "run" the documentation?
@plone plone deleted a comment from prashant235913 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant