Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a custom css class on a mosaic grid row in the advanced editor should be disabled if the layout is not customisable yet. #423

Open
fredvd opened this issue Sep 4, 2018 · 1 comment

Comments

@fredvd
Copy link
Member

fredvd commented Sep 4, 2018

When I double click on a mosaic grid row in the advanced view (press alt) in the Mosaic editor, I can set a custom css class on the row.

customclass1

When I close the input field, my class is listed in the bottom right of the mosaic grid row.

customclass2

But when I save the layout and go to edit again in the plone toolbar. , my custom css class is no longer there.

Tested with plone.app.mosaic master using test-5.1.coredev.cfg (Plone 5.1.4.dev0, plone.app.mosaic 2.1.2dev0). Tested with Chrome and Firefox. The webbrowser javascript console shows no errors.

@fredvd fredvd changed the title Setting a custom css class on a mosiac grid row in the advanced editor is not saved Setting a custom css class on a mosaic grid row in the advanced editor is not saved Sep 4, 2018
@fredvd
Copy link
Member Author

fredvd commented Sep 4, 2018

And.. 20 minutes later I realise the underlying issue. It's possible to set the css class in the advanced view of the layout editor even if you haven't customised the layout first.

The css-class editing feature shouldn't be available as long as the basic content layout template is still in use and the layout hasn't been made customisable on the context.

@fredvd fredvd changed the title Setting a custom css class on a mosaic grid row in the advanced editor is not saved Setting a custom css class on a mosaic grid row in the advanced editor should be disabled if the layout is not customisable yet. Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant