-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommended CSS classes for mosaic-grid-row #593
Comments
|
I also made a similar script and thought about an upgrade step. But it later got very project specific, so I didn't post it here. But in general the We could think of updateing these "standard" classes in version
|
I have a site with Mosaic that started out on Plone 5.1, and was migrated to 5.2 and 6.0. It has a few custom content layouts that have classes that don't seem to do anything and that don't result in any matches in Mosaic code, nor custom code for this site. These are classes like
mosaic-width-half
andmosaic-position-leftmost
that were set by a previous Mosaic version.So I started wondering which classes are expected next to
mosaic-grid-cell
.When I search in Mosaic itself in the content layouts, I get this:
Is
mosaic-position-0
still needed? A further search in Mosaic gives no result.col
orcol-*
seem fine, and help for Bootstrap 5.When using the Format menu, I can add
mosaic-grid-row-fluid/dark
. This can be expanded with custom code. And in issue #478 there is a discussion on which classes to add here in a way that works responsively.I guess if there are classes that do not do anything, then it does not hurt, except that it can get confusing for anyone who looks at the html.
Main question: does it make sense to write an upgrade step for this, removing some no longer supported classes and adding some new, especially
col
when it is not there (norcol-*
)?Or would this be something that is very project specific and does not translate well to a general Mosaic upgrade step?
I will share a script in the next comment.
The text was updated successfully, but these errors were encountered: