Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /customizing-volto-light-theme/installing-vlt.html #912

Open
ramiroluz opened this issue Jan 9, 2025 · 3 comments
Open

Issue on page /customizing-volto-light-theme/installing-vlt.html #912

ramiroluz opened this issue Jan 9, 2025 · 3 comments

Comments

@ramiroluz
Copy link
Member

Check if the instructions on configuring block addons on the package.json and volto.config.js

https://training.plone.org/customizing-volto-light-theme/installing-vlt.html#step-2-install-block-add-ons

I was testing and in my case I needed to configure dependencies for the block addons in the package.json

Not sure if it is needed but I also added to volto.config.js addons list.

@ramiroluz
Copy link
Member Author

Would like someone to test and confirm it is needed or not to configure dependencies and/or volto.config.js

To reproduce just follow the Customizing volto light theme training until chapter 3.

@stevepiercy
Copy link
Contributor

@sneridagh @danalvrz would you please take a quick look and respond to @ramiroluz? Thank you!

@sneridagh
Copy link
Member

@ramiroluz when you say "dependencies" you mean package.json dependencies key? In case you are in cookieplone, you don't need to set them up, although doing it is ok too (they are peerDependencies of VLT, so pnpm install them anyways).

Regarding the addons key, which is the way that you tell Volto to install the addon in your project, yes, you need to either do it in your project addon or in volto.config.js. No matter what you do it will work, since both are valid. However, it's recommended you do it inside your project addon, since it's totally portable and resilient to migrations by rebuilding the cookieplone boilerplate. Having declared the theme in volto.config.js is mandatory and can't be done from the addon.

Does this answer your question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants