Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making http calls proxy-aware #57

Open
edublancas opened this issue Mar 29, 2023 · 0 comments
Open

making http calls proxy-aware #57

edublancas opened this issue Mar 29, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@edublancas
Copy link
Contributor

corporate environments often have HTTP proxies; however, some of our calls are ignoring the proxy settings (often set via an environment variable).

to see the full context: #55

I'm assuming posthog is already taking care of it, but we still have two calls where we use HTTPSConnection that are most likely ignoring proxy settings

based on this, it looks like the requests library already takes care of this, so we can simply switch the calls to use requests (although we should verify that these assumptions are correct). Since the posthog package already has requests as a dependency, we are not really adding new dependencies, although we should explicitly put in our setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant