Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH:] Cumulative Gain Chart: Allow single line version #345

Open
emrynHofmannElephant opened this issue Apr 5, 2024 · 0 comments
Open

Comments

@emrynHofmannElephant
Copy link

Just wondering if there could be a small change to the function here:

So that it allows for one set of predicted probabilities (instead of requiring two). In particular this would require a change from y_score to y_pred, and likely either the removal of the second call to _cumulative_gain_curve() on line 164 & 171.

As this function is limited to the binary case anyway, the second line is redundant, as it is just the inverse probability of the other. Therefore, in case both lines are needed, a simple input check (y_score.shape[1]) & calculation could generate the second set instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant