-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is SIGTERM reaching the app? #5
Comments
Looks like this is definitely the case due to the way we don't Important note: no, we totally do |
Since the command in the Procfile is itself a Bash command (ie. a script), I'm not certain there's a way around this (other than to have everybody go around and start adding "exec" to their Procfiles). |
Actually, wait a tic, are Procfiles Bash scripts? I shouldn't think they are, actually. It seems more likely to me that they'd be processes and arguments (with maybe some shell expansion). More about this problem in progrium/buildstep#114 |
So, from buildstep's comments, it sounds like the cleanest way to solve this is to vendor in the |
Actually, you know what? We can do better, by piping the Ruby procfile read to OTOH, does forego handle shell expansion? Is that a documented feature of Procfiles? |
http://veithen.github.io/2014/11/16/sigterm-propagation.html seems like it might be necessary (if we want to keep |
Am I confusing SIGINT with SIGTERM? Does Bash actually forward SIGTERM to a job that is running and not backgrounded? See http://www.vidarholen.net/contents/blog/?p=34, http://git.savannah.gnu.org/cgit/bash.git/tree/jobs.c#n2411 |
There might also be something to running the bash command inside another bash command that runs the second Bash command asynchronously and kills the inner Bash command's process group ( |
Per all the whining I just did in progrium/buildstep#102, running the command via |
Okay, this is definitely not doing anything more complex than So the question becomes: is |
THAT'S THE PROBLEM npm/npm#4603 |
Moving to rectify: heroku/heroku-buildpack-nodejs#217 |
Stopping the old container seems to always time out. Is SIGTERM not being forwarded to the app we start?
The text was updated successfully, but these errors were encountered: