-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps for 27 #4338
Update deps for 27 #4338
Conversation
Use rabbitmq_common with a fix pma/amqp#231
Override minimum_otp_vsn for worker_pool (We still use Erlang 26/25 on CI
d467961
to
dcfee1f
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / dcfee1f small_tests_25 / small_tests / dcfee1f small_tests_26 / small_tests / dcfee1f small_tests_26_arm64 / small_tests / dcfee1f ldap_mnesia_25 / ldap_mnesia / dcfee1f dynamic_domains_mysql_redis_26 / mysql_redis / dcfee1f ldap_mnesia_26 / ldap_mnesia / dcfee1f dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / dcfee1f dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / dcfee1f internal_mnesia_26 / internal_mnesia / dcfee1f pgsql_cets_26 / pgsql_cets / dcfee1f dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / dcfee1f pgsql_mnesia_25 / pgsql_mnesia / dcfee1f pgsql_mnesia_26 / pgsql_mnesia / dcfee1f mssql_mnesia_26 / odbc_mssql_mnesia / dcfee1f mysql_redis_26 / mysql_redis / dcfee1f |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4338 +/- ##
==========================================
- Coverage 84.33% 84.32% -0.01%
==========================================
Files 553 553
Lines 33731 33731
==========================================
- Hits 28447 28444 -3
- Misses 5284 5287 +3 ☔ View full report in Codecov by Sentry. |
rebar.config
Outdated
@@ -217,7 +221,8 @@ | |||
{override, jwerl, [{plugins, [rebar3_elixir, rebar3_hex]}]}, | |||
%% GraphQL pulls geas_rebar3, which is a dev dependency | |||
%% geas takes some time to compile, but we do not need it | |||
{override, graphql, [{plugins, [rebar3_hex]}]} | |||
{override, graphql, [{plugins, [rebar3_hex]}]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, can we fix this directly on the dep? https://github.com/esl/graphql-erlang? We have our own fork so it's easy to fix there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR created esl/graphql-erlang#5
@@ -118,7 +119,10 @@ | |||
{jwerl, "1.2.0"}, | |||
{cpool, "0.1.0"}, %% Do not upgrade cpool to version 0.1.1, it has bugs | |||
{nkpacket, {git, "https://github.com/esl/nkpacket.git", {branch, "mongooseim-ranch-compatibility"}}}, | |||
{nksip, {git, "https://github.com/arcusfelis/nksip.git", {branch, "mu-fix-dialyzer"}}} | |||
{nksip, {git, "https://github.com/arcusfelis/nksip.git", {branch, "mu-fix-dialyzer"}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could just get rid of these nk dependencies to begin with...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 4e5a085 small_tests_25 / small_tests / 4e5a085 small_tests_26 / small_tests / 4e5a085 small_tests_26_arm64 / small_tests / 4e5a085 ldap_mnesia_25 / ldap_mnesia / 4e5a085 dynamic_domains_mysql_redis_26 / mysql_redis / 4e5a085 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4e5a085 ldap_mnesia_26 / ldap_mnesia / 4e5a085 pubsub_SUITE:tree+basic:publish_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 4e5a085 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 4e5a085 internal_mnesia_26 / internal_mnesia / 4e5a085 pgsql_cets_26 / pgsql_cets / 4e5a085 pgsql_mnesia_25 / pgsql_mnesia / 4e5a085 mysql_redis_26 / mysql_redis / 4e5a085 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_574@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_574@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_574@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_574@localhost/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... pgsql_mnesia_26 / pgsql_mnesia / 4e5a085 mssql_mnesia_26 / odbc_mssql_mnesia / 4e5a085 ldap_mnesia_26 / ldap_mnesia / 4e5a085 mysql_redis_26 / mysql_redis / 4e5a085 |
This PR addresses "compile on Erlang 27".
Proposed changes include: