New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken match in Wabbit.GenStage.noreply_callback #15

Open

h4cc opened this issue Mar 14, 2018 · 0 comments

h4cc commented Mar 14, 2018 •

edited

Loading

There is a bug in this function:
https://github.com/pma/wabbit/blob/master/lib/wabbit/gen_stage.ex#L271

There is not "module" key in state:
https://github.com/pma/wabbit/blob/master/lib/wabbit/gen_stage.ex#L6

Fix could look like this:

  defp noreply_callback(callback, args, %__MODULE__{mod: module} = state) do
    handle_noreply_callback apply(module, callback, args), state
  end

Hint: Using %__MODULE__{} for matches will let the compiler validate keys.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment