Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colours from item custom names leak into /give output #5342

Open
dktapps opened this issue Oct 14, 2022 · 0 comments
Open

Colours from item custom names leak into /give output #5342

dktapps opened this issue Oct 14, 2022 · 0 comments
Labels
Category: UI Related to the user interface (e.g. commands, terminal output) Easy task Probably really easy to do, good task for first-time contributors Status: Debugged Cause of the bug has been found, but not fixed

Comments

@dktapps
Copy link
Member

dktapps commented Oct 14, 2022

Issue description

Since the formatting codes from Item->getName() are not contained when embedding them into the translations, this happens:

image

In this image, only the Legendary part should be grey. The rest of the message should be white.

This is likely a problem in other areas too, and it's rather inconvenient to fix in versions prior to the introduction of TextFormat::addBase(), so this probably won't be fixed until after 4.11.

Steps to reproduce the issue

  1. /give yourself an item whose custom name contains formatting codes
  2. Notice that the remainder of the audit message after the item name is the same format and colour as the item name itself

OS and versions

  • PocketMine-MP: 4.9.1 / 5.0.0-ALPHA4
@dktapps dktapps added Status: Debugged Cause of the bug has been found, but not fixed Category: UI Related to the user interface (e.g. commands, terminal output) labels Oct 14, 2022
@dktapps dktapps added the Easy task Probably really easy to do, good task for first-time contributors label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: UI Related to the user interface (e.g. commands, terminal output) Easy task Probably really easy to do, good task for first-time contributors Status: Debugged Cause of the bug has been found, but not fixed
Projects
None yet
Development

No branches or pull requests

1 participant