THREE.Scene: .dispose() has been removed #824
JustFly1984
started this conversation in
General
Replies: 1 comment 3 replies
-
three uses webgl2 now that breaks some shaders, you cant use the word "texture" for instance. they also took away scene.dispose. "new" was a component we were testing. examples aren't really that critical - i update them every once in a while. but i keep three up to date for type generation thats why examples can fall behind. three is the most breaking change prone library on this planet. |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I've forked the repo, and running examples CRA locally. I'm looking at several examples which has errors in the browser console.
This one I can't find nothing by googling. It happens in several examples then I leave the page, which renders a component.
Components with reproduction:
Font
,MultiScene
,SelectiveBloom
Bloom has different error:
Not sure what is going on with Selection component:
In
Concurrent
component there is only warnings:All other components seem to be working ok. I have fixed some memory leaks, and added eslint-plugin-react-perf, and fixed lots of highlighted perf issues in src and all examples. I've fixed typescript React import issues.
Here is my PR: #823
Please review.
Beta Was this translation helpful? Give feedback.
All reactions