Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m365 spo homesite add #6488

Open
reshmee011 opened this issue Nov 16, 2024 · 4 comments
Open

m365 spo homesite add #6488

reshmee011 opened this issue Nov 16, 2024 · 4 comments

Comments

@reshmee011
Copy link
Contributor

Usage

m365 spo homesite add

Description

Create a viva connection experience

Options

Option Description
-h --homeSiteUrl <homeSiteUrl> The home site url to create a viva connection experience

Examples

Create a viva connection experience

m365 spo homesite add --homeSiteUrl "https://reshmeeauckloo.sharepoint.com/sites/testcomms"

Default properties

  • Title
  • Url

Additional Info

This is to fix bug #6066 which requires the additional cmdlet to add home site which is separate from the update home site.

After peer review, I am happy to work on it.

@milanholemans
Copy link
Contributor

Hi, @reshmee011, thanks for the issue. A few remarks from my side:

  • To me it seems odd that the description tells us we are doing something with Viva Connections, while it's an spo command. Do you think Adds a new site as home site or something like that covers the load?
  • For the option, instead of repeating homeSite in the option name, I'd just opt for -u, url <url>.
  • Since this is an add command, default properties are not needed. This is only required for list commands.

Other command-related questions:

  • Does this mean that we should update the description of the command spo homesite set so that it only updates a home site instead of adding it?
  • Should we update spo homesite get and spo homesite remove with a required siteUrl option?

@reshmee011
Copy link
Contributor Author

@milanholemans : My answers to the questions

  • To me it seems odd that the description tells us we are doing something with Viva Connections, while it's an spo command. Do you think Adds a new site as home site or something like that covers the load?

As per Ms documentation from https://learn.microsoft.com/en-us/viva/connections/set-up-admin-center, it's "Create a Connections experience"

For the option, instead of repeating homeSite in the option name, I'd just opt for -u, url . Done
Since this is an add command, default properties are not needed. This is only required for list commands.Done

Other command-related questions:

Does this mean that we should update the description of the command spo homesite set so that it only updates a home site instead of adding it?
We can add the Home Site/Connections Experience as well as setting the properties of the Home Site/Connections Experience

Should we update spo homesite get and spo homesite remove with a required siteUrl option? Yes, we should update them, the endpoints will have to change to ones that can accept the siteUrl parameter.

Documentation how to programmatically manage those viva connection experiences is lacking. I am using the browser's developer tools to identify the endpoints.

@milanholemans
Copy link
Contributor

As per Ms documentation from https://learn.microsoft.com/en-us/viva/connections/set-up-admin-center, it's "Create a Connections experience"

Yeah, we are kinda in a gray area here. Setting up the home site automatically creates a VC experience as well, but in this case that's not really the purpose of the command, but rather a side-effect I guess?

Does this mean that we should update the description of the command spo homesite set so that it only updates a home site instead of adding it? We can add the Home Site/Connections Experience as well as setting the properties of the Home Site/Connections Experience

I didn't notice the other issue you've created, so you can ignore this comment.

Should we update spo homesite get and spo homesite remove with a required siteUrl option? Yes, we should update them, the endpoints will have to change to ones that can accept the siteUrl parameter.

Is it possible for you to specify issues for this as well? We would really appreciate that. Note that these commands should have a required option url, but since CLI is backward compatible until we create a new major version, we'll have to implement is as an optional parameter and show a deprecation warning when someone doesn't provide a URL.

@reshmee011
Copy link
Contributor Author

reshmee011 commented Nov 16, 2024

Yeah, we are kinda in a gray area here. Setting up the home site automatically creates a VC experience as well, but in this case that's not really the purpose of the command, but rather a side-effect I guess?

We can leave it Add a Home Site.

Is it possible for you to specify issues for this as well? We would really appreciate that. Note that these commands should have a required option url, but since CLI is backward compatible until we create a new major version, we'll have to implement is as an optional parameter and show a deprecation warning when someone doesn't provide a URL.

I have raised issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants