You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For error, warn, info, debug, and trace, we'd like to use fmt::format style formatting instead of std::ostream (internal implementation details). For example, the following usage is not that clear:
https://github.com/poac-dev/poac/blob/23471b6c352809dff0d0655cbb47586e1c8e3358/src/Logger.hpp
For
error
,warn
,info
,debug
, andtrace
, we'd like to usefmt::format
style formatting instead ofstd::ostream
(internal implementation details). For example, the following usage is not that clear:poac/src/main.cc
Lines 94 to 96 in 23471b6
We may want to do like this instead:
We can use
fmt::format
for arguments to these loggers and we do, but the new interface will be clearer:poac/src/Cmd/Build.cc
Lines 52 to 58 in 23471b6
logger::info
can be:Theoretically,
error
,warn
,debug
, andtrace
's function arguments would be like:And
info
has:Note that the actual implementation may be different as to conform to the current implementation style.
The text was updated successfully, but these errors were encountered: