Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Supplement "Add Mining Key" by extra fields to allow adding three keys at once #131

Closed
varasev opened this issue Jun 4, 2018 · 4 comments
Assignees

Comments

@varasev
Copy link
Contributor

varasev commented Jun 4, 2018

Problem: now VotingToChangeKeys smart contract allows to create ballot to add new validator by adding three keys at once (mining/voting/payout), but the web interface of Voting DApp doesn't allow to use this feature yet.

Solution: add an ability to create three validator's keys at once to the web interface of Voting DApp.

This issue is related to #83 and poanetwork/poa-network-consensus-contracts#92.

@varasev
Copy link
Contributor Author

varasev commented Jun 9, 2018

I've added extra fields for creating a new validator in varasev@661beb1.

This hasn't been tested yet with the new contracts, but web interface works fine. Now it looks like this:

screen

@varasev
Copy link
Contributor Author

varasev commented Jun 11, 2018

This is how a ballot card looks:

image

@varasev
Copy link
Contributor Author

varasev commented Jun 12, 2018

Commits with the changes described above:

varasev@661beb1
varasev@4295932
varasev@944db87
varasev@8da4912
varasev@d075d8a

The corresponding PR will be created after security audit of smart contracts is done.

@varasev
Copy link
Contributor Author

varasev commented Jun 19, 2018

Done in #134.

@varasev varasev closed this as completed Jun 19, 2018
@varasev varasev mentioned this issue Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant