Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track ingest table can be populated with granules that aren't loaded into Hydrocron #235

Open
torimcd opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@torimcd
Copy link
Collaborator

torimcd commented Sep 17, 2024

The load granule module can add entries for granules that are not loaded into Hydrocron. For example, we only have tables for the prior lakes. If an observed lake granule is manually sent to the load_granule lambda, it will fail to load into the hydrocron tables but it will load the granule into the track table specified in the lambda event, regardless of feature type.

This is not critical for the 1.4.0 release because the track ingest feature is not complete, and you can tell which entries are affected by granuleUR and the expected feature count will be zero. This also shouldn't happen in OPS since the load_granule lambda is only ever run via the CNM lambda or the bulk load_data lambda which both handle this edge case correctly. But we'll need to fix this and clear out bad entries that end up in SIT & UAT prior to the next release.

@torimcd torimcd added the bug Something isn't working label Sep 17, 2024
@torimcd torimcd self-assigned this Sep 23, 2024
@frankinspace
Copy link
Member

Seems like this is a low likelihood and low impact if it were to happen. @nikki-t will check with @torimcd on details.

@nikki-t
Copy link
Collaborator

nikki-t commented Oct 9, 2024

It is also possible to enter a collection short name that doesn't match the corresponding Hydrocron SWOT table name or Hydrocron track ingest table name as in:

  "collection_shortname": "SWOT_L2_HR_RiverSP_reach_2.0",
  "hydrocron_table": "hydrocron-swot-node-table",
  "hydrocron_track_table": "hydrocron-swot-node-track-ingest-table",

where the reach shortname is entered while the node-level tables are entered.

We should place conditional statements in the track ingest Lambda code to test that the "event" arguments align.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants