Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net2Cog should not default to Web Mercator projection if CRS is not explicitly set. #12

Open
autydp opened this issue Oct 18, 2023 · 2 comments
Labels
invalid This doesn't seem right

Comments

@autydp
Copy link
Collaborator

autydp commented Oct 18, 2023

I recommend removing the code that sets CRS to Web Mercator in the absence of any CRS in the source data.

  • HyBIG will reproject if necessary.
  • Most often, the absence of an explicit CRS implies Geographic (LatLon) projection, not Web-Mercator.
  • RioXarray (CoGeo? - Cloud Optimized GeoTIFF package) interprets correctly (as Geographic) without CRS.
@autydp autydp added the invalid This doesn't seem right label Oct 18, 2023
@autydp
Copy link
Collaborator Author

autydp commented Oct 18, 2023

Note - if the original intention was for PO.DAAC's browse-image generation to always produce Web-Mercator images, I might suggest this be moved to the chaining implementation that calls HyBIG, or even the external invocation of that chain - where the CRS can be asserted in the request - rather than being burned into the Net2Cog implementation.

@frankinspace
Copy link
Member

frankinspace commented Nov 2, 2023

I agree, we can remove the code that sets CRS to Web Mercator in the absence of any CRS in the source data.

I think that made it in originally as I was messing with settings to try to get the image to display correctly (by 'correctly' I mean not-inverted #7. But I'm coming to understand that is not actually a problem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants