Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Podverse Mission Statement translatable #1926

Closed
mitchdowney opened this issue Sep 4, 2023 · 5 comments
Closed

Make Podverse Mission Statement translatable #1926

mitchdowney opened this issue Sep 4, 2023 · 5 comments
Assignees
Labels
bug Something isn't working ready to deploy The work has been approved and merged translations

Comments

@mitchdowney
Copy link
Member

There are some instances of text in the web and mobile app that we have purposely not allowed to be translated into other languages. My primary reason for doing with this text is that I want to be extra careful and do extra review, since this text may relate to our mission statements as an organization, or have legal implications.

That said, maybe I am being overly cautious. I'm not sure how to proceed on this at the moment, but I think it would be useful to at least organize examples of the screens / pages that are not translatable at this time for those reasons.

Screenshot_2023-09-03-14-31-29-579_com podverse

related to: podverse/podverse-web#1185

@mitchdowney mitchdowney added bug Something isn't working translations labels Sep 4, 2023
@Marzal
Copy link

Marzal commented Sep 21, 2023

Hi, just yesterday I updated de Spanish translation of podverse-web and I did have available that string to translate.

Is the lock on the PR bot on GitHub?

https://hosted.weblate.org/translate/podverse/podverse-web/es/?q=Podverse+creates+free+and+open+source+software+to&sort_by=-priority%2Cposition&checksum=

@mitchdowney
Copy link
Member Author

@Marzal that "Mission statement" string should be translatable and should surface in the web app. I'm not sure I understand your question? If you are wondering why the changes aren't reflected on the web site yet, I just need to release a new version of the web app. It's a very simple process with our Github Actions, so I will do that right now.

Also, thank you very much for the Spanish translations! You did a lot of work there.

@Marzal
Copy link

Marzal commented Sep 22, 2023

@mitchdowney let me reformulate:
In the image, what's the text that is not translatable? I thought it was the part in English, but some of these strings in English are available for translation in the platform. I was asking, just in case I have to mark them with "revisar" to have a special review with them.

The platform makes translation quite easy, the next time my daughter is out with her grandpa I will try to do the Mobile app strings.

@mitchdowney
Copy link
Member Author

@Marzal ahh, so, the link you provided is actually for the podverse-web repo, which is for the website, but this ticket is for the mobile app, so I was confused. This text you're seeing in the screenshot could be translatable. It's more of the legal-related text I'm concerned about. I'll assign this ticket to me so I remember to make the text translatable in the mobile app.

@mitchdowney mitchdowney self-assigned this Sep 25, 2023
@mitchdowney
Copy link
Member Author

@Marzal this should be translatable as of 4.15.1

@mitchdowney mitchdowney changed the title Create a list of all the text we have not yet allowed to be translated Make Podverse Mission Statement translatable Nov 28, 2023
@mitchdowney mitchdowney added the ready to deploy The work has been approved and merged label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to deploy The work has been approved and merged translations
Projects
None yet
Development

No branches or pull requests

2 participants