Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to tell users which trades are not approved for flair and a brief reason why #615

Open
pkmnbumba opened this issue Nov 19, 2017 · 1 comment
Assignees

Comments

@pkmnbumba
Copy link
Contributor

Two parts to this:

Mod side

  • When looking through their profile, mods should be able to approve (checkbox) or provide a reason why a trade was not approved (dropdown)
  • There will be defaults but also an 'Other' option that should create a textbox for mods to provide a reason

User side

  • When reading through their profile, users should be able to see which trades were not approved and the selected reason why

After discussion, we will not show which trades are approved, only the ones that aren't approved.

This will allow us to create an automated message for denying flair apps

@pkmnbumba
Copy link
Contributor Author

pkmnbumba commented Dec 18, 2017

Right now, a reference not being approved means either a mod hasn't looked at it yet or the reference didn't count for flair for some reason

approved: "boolean",

That said, 'false' for approved isn't exactly clear. There are two main ways that I see that we can deal with this:

  1. Use a new boolean just for disapprovals
  2. We can use the approved: false and have it default to 'Mod hasn't seen this yet', but we probably don't want people seeing that by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant