From 06abd2daf333c8b52e7663e95b4a620c81c213bd Mon Sep 17 00:00:00 2001
From: SHIMA Tatsuya <tatsuya_shima@biophenoma.com>
Date: Wed, 22 May 2024 03:40:51 +0000
Subject: [PATCH] wip fix rolling options [skip ci]

---
 src/rust/Cargo.toml      |  1 +
 src/rust/src/lazy/dsl.rs | 19 +++++--------------
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/rust/Cargo.toml b/src/rust/Cargo.toml
index d8f7df3e6..6d3adcbf8 100644
--- a/src/rust/Cargo.toml
+++ b/src/rust/Cargo.toml
@@ -139,6 +139,7 @@ features = [
   "replace",
   "rle",
   "rolling_window",
+  "rolling_window_by",
   "round_series",
   "row_hash",
   "rows",
diff --git a/src/rust/src/lazy/dsl.rs b/src/rust/src/lazy/dsl.rs
index 744bb928f..a9ed08159 100644
--- a/src/rust/src/lazy/dsl.rs
+++ b/src/rust/src/lazy/dsl.rs
@@ -684,18 +684,12 @@ impl RPolarsExpr {
         weights: Robj,
         min_periods: Robj,
         center: Robj,
-        by: Robj,
-        closed: Robj,
-        warn_if_unsorted: Robj,
     ) -> RResult<Self> {
-        let options = pl::RollingOptions {
-            window_size: pl::Duration::parse(robj_to!(str, window_size)?),
+        let options = pl::RollingOptionsFixedWindow {
+            window_size: robj_to!(usize, window_size)?,
             weights: robj_to!(Option, Vec, f64, weights)?,
             min_periods: robj_to!(usize, min_periods)?,
             center: robj_to!(bool, center)?,
-            by: robj_to!(Option, String, by)?,
-            closed_window: robj_to!(Option, ClosedWindow, closed)?,
-            warn_if_unsorted: robj_to!(bool, warn_if_unsorted)?,
             fn_params: None,
         };
         let quantile = robj_to!(f64, quantile)?;
@@ -2624,15 +2618,12 @@ pub fn make_rolling_options(
     by_null: Robj,
     closed_null: Robj,
     warn_if_unsorted: Robj,
-) -> RResult<pl::RollingOptions> {
-    Ok(pl::RollingOptions {
-        window_size: pl::Duration::parse(robj_to!(str, window_size)?),
+) -> RResult<pl::RollingOptionsFixedWindow> {
+    Ok(pl::RollingOptionsFixedWindow {
+        window_size: robj_to!(usize, window_size)?,
         weights: robj_to!(Option, Vec, f64, weights)?,
         min_periods: robj_to!(usize, min_periods)?,
         center: robj_to!(bool, center)?,
-        by: robj_to!(Option, String, by_null)?,
-        closed_window: robj_to!(Option, ClosedWindow, closed_null)?,
-        warn_if_unsorted: robj_to!(bool, warn_if_unsorted)?,
         ..Default::default()
     })
 }