Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.0 release #466

Closed
grantmcdermott opened this issue Nov 3, 2023 · 6 comments · Fixed by #479
Closed

0.10.0 release #466

grantmcdermott opened this issue Nov 3, 2023 · 6 comments · Fixed by #479
Milestone

Comments

@grantmcdermott
Copy link
Collaborator

I know that 0.9.0 just came out earlier in the week. But can I selfishly nudge for a 0.9.1 patch release? This is mostly to catch #442, which in turn will allow me to demonstrate hive-dataset I/O for an internal workshop that I'm giving at work.

Again don't feel obliged to rush a patch release. But it would be nice for me to demonstrate the same functionality across both the R and Python Polars implementations.

@eitsupi
Copy link
Collaborator

eitsupi commented Nov 3, 2023

I think this should be 0.10 as it is a breaking change.
(Of course, according to semantic versioning, it's okay to release breaking changes in 0.9.1.)

@etiennebacher
Copy link
Collaborator

I think so too and it would be nice if #455 could be included since it's close to being complete. In a sense that would be enough new things to justify a new release but it feels a bit weird to have two "major" releases in a week

@grantmcdermott
Copy link
Collaborator Author

Cool, don't stress if it's going to be a more than a patch release. I'll tell my audience that this functionality is just around the corner...

Will close this then if the next release is going to be be 0.10.

@eitsupi
Copy link
Collaborator

eitsupi commented Nov 4, 2023

I don't think frequent major releases are a problem here, as this package cannot be submitted to CRAN at this stage.
So I'm happy to be able to release 0.10 in the next week or so.

Note that thanks to the new binary release mechanism, it is now possible to quickly install a specific version from GitHub.

> Sys.setenv(NOT_CRAN="true")
> Sys.setenv(PKG_SYSREQS="false")
> pak::pak("pola-rs/[email protected]")

→ Will install 1 package.Will download 1 package with unknown size.
+ polars   0.9.0 [bld][cmp][dl] (GitHub: d3c0b03) +cmake, ✖ rustc, ✖ cargoMissing 3 system packages. You'll probably need to install them manually:
+ cargo  - polars
+ cmake  - polars
+ rustc  - polars
ℹ Getting 1 pkg with unknown size
✔ Cached copy of polars 0.9.0 (source) is the latest build
✔ No downloads needed, all packages are cached
ℹ Packaging polars 0.9.0
✔ Packaged polars 0.9.0 (2.6s)
ℹ Building polars 0.9.0
✔ Built polars 0.9.0 (42.2s)
✔ Installed polars 0.9.0 (github::pola-rs/r-polars@d3c0b03) (734ms)
✔ 1 pkg + 1 dep: kept 1, added 1 [47.9s]

@eitsupi eitsupi changed the title 0.9.1 release 0.10.0 release Nov 4, 2023
@eitsupi eitsupi reopened this Nov 4, 2023
@eitsupi eitsupi added this to the 0.10 milestone Nov 4, 2023
@eitsupi
Copy link
Collaborator

eitsupi commented Nov 8, 2023

@etiennebacher Are there any other changes on the Rust side that you would like to include in 0.10.0?
If not, I do a library release once everything currently in the milestone has been merged, and then create the 0.10.0 release.

@etiennebacher
Copy link
Collaborator

All good for me, #470 is not ready. Go ahead with 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants