You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to the addition of competitions on Polaris, we've had to introduce many conditionals in the PolarisHubClient to manage which APIs are triggered based on the artifact type (e.g. standard or competition) being processed. While these conditional work, they introduce complexities that reduce readability and future extensibility.
As per this comment on #121, we should introduce an additional enum class to better handle these conditionals in a way that is cleaner and offers better extensibility when new artifacts are introduced in the future.
Description
A new enum class should be created that will abstract away much of the complexity associated with managing important data points that are tied to an artifact but not included in the artifact's model (e.g. hub_url). It could look something like this (as suggested in the above PR comment):
Context
Due to the addition of competitions on Polaris, we've had to introduce many conditionals in the
PolarisHubClient
to manage which APIs are triggered based on the artifact type (e.g.standard
orcompetition
) being processed. While these conditional work, they introduce complexities that reduce readability and future extensibility.As per this comment on #121, we should introduce an additional enum class to better handle these conditionals in a way that is cleaner and offers better extensibility when new artifacts are introduced in the future.
Description
A new enum class should be created that will abstract away much of the complexity associated with managing important data points that are tied to an artifact but not included in the artifact's model (e.g.
hub_url
). It could look something like this (as suggested in the above PR comment):Acceptance Criteria
PolarisHubClient
to use an instantiated object from the new enum classThe text was updated successfully, but these errors were encountered: