Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail page is hidden when canvas graphs are used. #106

Open
Nikoli opened this issue Nov 11, 2014 · 8 comments
Open

Detail page is hidden when canvas graphs are used. #106

Nikoli opened this issue Nov 11, 2014 · 8 comments

Comments

@Nikoli
Copy link

Nikoli commented Nov 11, 2014

Canvas graphs do not have links to detail.php?p=... pages, please fix.
Big graphs with 2hour 8hour day week month quarter year selectors are useful.

@pommi
Copy link
Owner

pommi commented Nov 11, 2014

You can use hybrid instead.

@pommi pommi closed this as completed Nov 11, 2014
@Nikoli
Copy link
Author

Nikoli commented Nov 11, 2014

I do not want to use server for generating images, this is task of clients. canvas supports urls fine, so why keep this pointless limitation?

@pommi
Copy link
Owner

pommi commented Nov 11, 2014

What about this 😃

@Nikoli
Copy link
Author

Nikoli commented Nov 12, 2014

Is it working fine for you? In my case canvas graphs in overview and other pages have links to detail.php now, but only graphs in detail.php are visible, other pages have them completely transparent.

@pommi
Copy link
Owner

pommi commented Nov 12, 2014

Yes, for me it's working fine in Iceweasel and Chromium.

@Nikoli
Copy link
Author

Nikoli commented Nov 22, 2014

After more investigating found what exactly triggers problem:

$CONFIG['rrd_fetch_method'] = 'async';

With default sync it works fine, used firefox and chromium-39 for testing.

@Lekensteyn
Copy link
Contributor

Pommi, please revert this. The change breaks the async fetch method and the alternative view sucks too because the page gets reloaded while the RRD file is already retrieved!

@Nikoli you can scroll in the graphs to get more detailled views. Does not work on mobile unfortunately.

Lekensteyn added a commit to Lekensteyn/CGP that referenced this issue Dec 14, 2014
pommi pushed a commit that referenced this issue Dec 14, 2014
@pommi
Copy link
Owner

pommi commented Dec 14, 2014

Ok, reverted for now.

@pommi pommi reopened this Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants