Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test is effectively an in-tree build #135

Open
SeanTAllen opened this issue Jun 7, 2020 · 0 comments
Open

Make test is effectively an in-tree build #135

SeanTAllen opened this issue Jun 7, 2020 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed needs discussion Needs to be discussed further

Comments

@SeanTAllen
Copy link
Member

So, in-tree builds are bad. We try to avoid them with all our makefiles. Everything goes into build/ however, we have tests that use the testdata in corral/test/test-data which in turn as lock.json files created there in the tree.

I have a PR open that adds a .gitignore to testdata to prevent lock.json files from being added. This is however, a workaround. Really as part of testing, the testdata should be copied into build and used from there.

How exactly we do this PATH wise is unclear. We don't have a good mechanism for this.

Additionally we need to make sure the makefile will correctly handle the dependency such that if any changes are made in corral/test/testdata that it will be updated in build.

@SeanTAllen SeanTAllen added enhancement New feature or request help wanted Extra attention is needed needs discussion Needs to be discussed further labels Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed needs discussion Needs to be discussed further
Projects
None yet
Development

No branches or pull requests

1 participant