You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, corral commands are passed to the Executor primitive along with a few other parameters that eventually effect what is being passed to the command's apply() method. This makes unit testing difficult as the parameters that are passed to the Executor are used for common checks across all commands before then being passed to the commands themselves.
A cleaner interface could look like initiating a CmdType with all (or most) of the parameters currently being passed to the Executor (and then subsequently to the CmdTypeapply()) or having separate CmdTypeInfo and CmdTypeAction traits that are initiated and will choose some of these parameters for you by default (e.g. the Logger).
Currently,
corral
commands are passed to theExecutor
primitive along with a few other parameters that eventually effect what is being passed to the command'sapply()
method. This makes unit testing difficult as the parameters that are passed to theExecutor
are used for common checks across all commands before then being passed to the commands themselves.A cleaner interface could look like initiating a
CmdType
with all (or most) of the parameters currently being passed to theExecutor
(and then subsequently to theCmdType
apply()
) or having separateCmdTypeInfo
andCmdTypeAction
traits that are initiated and will choose some of these parameters for you by default (e.g. theLogger
).Related to #138
The text was updated successfully, but these errors were encountered: