Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with constraint solving default #172

Open
SeanTAllen opened this issue Feb 8, 2021 · 0 comments
Open

Bug with constraint solving default #172

SeanTAllen opened this issue Feb 8, 2021 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed triggers release Major issue that when fixed, results in an "emergency" release

Comments

@SeanTAllen
Copy link
Member

In constraint.pony:

      try
        Constraints._parse_constraints(version)?
        "main" // Is a constraint: use main until update.
      else

that default, will fail entirely if the branch doesn't exist. Given that GitHub is making it easy to switch default branch names, this is highly problematic. Our tests for constraints fail if the repo being pulled doesn't have said branch. Which is problematic given the constraint exists. This is a bug that should be fixed.

To reproduce, change that "main" to a non-existent branch in our corral-test-repo (e.g. free-candy-branch) and run the integration tests.

@SeanTAllen SeanTAllen added bug Something isn't working help wanted Extra attention is needed triggers release Major issue that when fixed, results in an "emergency" release labels Feb 8, 2021
@SeanTAllen SeanTAllen changed the title Bug with constraint solver default Bug with constraint solving default Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed triggers release Major issue that when fixed, results in an "emergency" release
Projects
None yet
Development

No branches or pull requests

1 participant