Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture_Type should not contain "ReferenceGenome" #66

Open
stschiff opened this issue Sep 25, 2023 · 0 comments
Open

Capture_Type should not contain "ReferenceGenome" #66

stschiff opened this issue Sep 25, 2023 · 0 comments

Comments

@stschiff
Copy link
Member

The choice "ReferenceGenome" for janno-field Capture_Type makes no sense in my view. Reference Genomes are typically not captured, and so should simply have that field missing. If we need a way to specify reference genomes, we should rather use a new choice-field in column Date_Type, which currently has "modern", and could also have "ReferenceGenome". But in Capture_Type this just makes no sense.

It's sadly hardly possible at all to make this a strict change, since it would mean that newer tools would never be able to parse old versions of packages containing reference genomes. So if we do something about this, we would have to make the software be lenient about it and issue a warning rather than a stop. I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant