Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packageVersion could be mandatory #87

Open
nevrome opened this issue Jan 13, 2025 · 1 comment
Open

packageVersion could be mandatory #87

nevrome opened this issue Jan 13, 2025 · 1 comment

Comments

@nevrome
Copy link
Member

nevrome commented Jan 13, 2025

Package versions are essential for many parts of our infrastructure. Various code in trident and elsewhere could be simpler if this information was guaranteed to be there. This would be a breaking change, but working around that may be worth it.

@stschiff
Copy link
Member

Yes, I think I'm with you on that!

I think as proposed by @TCLamnidis, there is an easy way to make this non-breaking, by simply setting unknown versions to 0.1.0 and spitting out a warning when reading such a package?

We could also think how to implement this in our Poseidon-Version check. Right now, we simply have a list of Poseidon-Versions supported by trident. If we follow the proposal above, we could extend that list towards old Poseidon-Versions, so that trident can read packages encoded with the older format. We could even come up with a smarter package-reading method, which makes versions mandatory for packages encoded in the new Poseidon-Version (refusing to read packages without version), but allowing old versions to be read by setting the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants