Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error saving comments #162

Open
Ulyanov-programmer opened this issue Oct 14, 2024 · 2 comments
Open

Error saving comments #162

Ulyanov-programmer opened this issue Oct 14, 2024 · 2 comments

Comments

@Ulyanov-programmer
Copy link

Hello!

While using your plugin, I noticed the following:

If attach a comment to a rule, regardless of whether it is embedded in another one or not, it will be displayed correctly.
(note that the preserveEmpty parameter is true)

Example
p {
  a {
    /* Text */
  }
}

/* to */

p {}

p a {
  /* Text */
}

However, if a comment is nested in a rule that has a different rule inside, it will not be nested:

Example
p {
  /* P Text */
  a {
    /* Text */
  }
}

/* to */

p {}

/* P Text */
p a {
  /* Text */
}

But it was expected:

p {
  /* P Text */
}

p a {
  /* Text */
}
@ai
Copy link
Member

ai commented Oct 14, 2024

Positioning comments right in all cases is too hard for me. So if you want to fix it, you need to send PR.

@Ulyanov-programmer
Copy link
Author

Done.
#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants