All the reference to the IBMCLOUD_API_KEY to be updated

[mkumatag]

What happened:

IBMCLOUD_API_KEY is been used in many places in the code, this needs to be fixed - https://github.com/search?q=repo%3Appc64le-cloud%2Fpvsadm%20IBMCLOUD_API_KEY&type=code

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• pvsadm version (use pvsadm version):
• Environment - On-Prem or IBM PowerVS:
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Others:

[mkumatag]

cc @kishen-v

[kishen-v]

/good-first-issue

[ppc64le-cloud-bot]

@kishen-v:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[manju956]

/assign

[kishen-v]

Hi @manju956,
Thanks for looking into this issue. We're deprecating the IBMCLOUD_API_KEY and will be usingIBMCLOUD_APIKEY instead.

All references need to refer IBMCLOUD_APIKEY.

Thanks!

[Karthik-K-N]

Hi @manju956, Thanks for looking into this issue. We're deprecating the IBMCLOUD_API_KEY and will be usingIBMCLOUD_APIKEY instead.

All references need to refer IBMCLOUD_APIKEY.

Thanks!

Whats the reason for this change, Wanted to know because we follow similar format in CAPIBM.

[kishen-v]

Hey @Karthik-K-N,
The go-sdk-core expects the API KEY to be exported as IBMCLOUD_APIKEY, at the package level, in order to use the same, we had to re-export the key from IBMCLOUD_API_KEY to IBMCLOUD_APIKEY to use the package. Hence, we are making the change.

pvsadm/cmd/root.go

Lines 49 to 52 in 5001afd

	// TODO : deprecate IBMCLOUD_API_KEY for IBMCLOUD_APIKEY
	// The GetAuthenticatorFromEnvironment requires "IBMCLOUD_APIKEY" to be set, apart from IBMCLOUD_API_KEY used in the project.
	// In order to use the resourcecontrollerv2's functionality, the IBMCLOUD_API_KEY is re-exported as IBMCLOUD_APIKEY.
	// Ref: github.com/ibm/go-sdk-core/[email protected]/core/config_utils.go, which is available from either from a credentials file, environment or VCAP service.

[kishen-v]

Fixed via: #671

/close

[ppc64le-cloud-bot]

@kishen-v: Closing this issue.

In response to this:

Fixed via: #671

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.