Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RWR calculations on the native grid the default #4

Open
ppharris opened this issue Oct 7, 2021 · 0 comments
Open

Make RWR calculations on the native grid the default #4

ppharris opened this issue Oct 7, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ppharris
Copy link
Owner

ppharris commented Oct 7, 2021

In common_analysis.make_analysis() the code defaults to using wfdei.regrid_wfdei():

    ###########################################################################
    # Get a function for deriving RWR output grid info.
    ###########################################################################
    if file_sftlf is None:
        regrid_model = wfdei.regrid_wfdei
    else:
        def regrid_model(res):
            grid = read_grid(file_sftlf)
            land = [[i] for i in range(grid.nl)]
            return grid, land

which is ultimately called as the hard-wired regrid_model(1). That means the user has to do more work to get the code to calculate RWR on the native input grid of the data (e.g., 0.5 deg for observations) than to calculate it on a 1 deg coarsened version of one particular native grid (WFDEI). It seems like this behaviour is the wrong way around for general use.

@ppharris ppharris added the enhancement New feature or request label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant